Rant against gatekeepers!
I had a feature deployment planned for this Tuesday. My manager was completely fine with it but asked me to get the PR approved by our senior engineer What my rant is about the a typical egoistic mentality of rejecting perfectly good work!
He starts of by saying “itna simple code kyun likha hai baccho jaisa?!” (why is this code written so simply like a child?) and then continues to say how he isn’t against readable code but my logic is too basic. He then goes on to say I should rewrite the whole module. Hell no I won’t ! Fuck you man! And fuck your gatekeeping!
Writing maintainable code is crucial to anyone’s sanity and team productivity. Also, rewriting everything would not only be inconvenient but also risky, defeating the purpose of a quick fix.
I feel so angry right now. Don’t know how I should approach this because I really don’t want to rewrite my logic on this task.
Egotistic mentality works both ways na?
Ask for a code review meeting. And there you can explain. Take down notes. Send the results on mail ccing your boss and his boss
Have an open and genuine discussion on the tradeoffs if you really believe your method is good. For our seniors their responsibility is to ensure that code is kept at high standard, not just getting the task done.
