ZippyRaccoon
ZippyRaccoon

Peer/PR Reviews methodology

How do PR reviews happen in your company? Are there any guidelines you follow to ensure Swift and meaningful reviews on your contributions? Any input or opinions are welcomed

21mo ago
Talking product sense with Ridhi
9 min AI interview5 questions
Round 1 by Grapevine
ZestyBurrito
ZestyBurrito

Make small PR. One working functionality at a time.
If renaming something that will reflect in multiple files don't send it with another logic.
Add Sonar and git leaks check.

ZippyRaccoon
ZippyRaccoon

In my company the PRs are linked with issues, and yes we are trying to ensure the issues created are not a combination of multiple tasks. First time hearing of sonar and git leak, will check it out thanks

ZestyBurrito
ZestyBurrito

Yes, we also have User stories, bugs, technical user stories, spikes etc.

SqueakyBoba
SqueakyBoba
Student21mo

I believe in most places the review system is kinda mess and main reason people don’t value it

ZippyRaccoon
ZippyRaccoon

Yes I would imagine so, and that's why we're trying to make sure we don't add ourselves to that list. At the moment the main issue we are facing is that PR reviews are not quick enough. A lot of PRs are going stale

WobblyBagel
WobblyBagel

We don't do PRs at all. 🤡

CosmicQuokka
CosmicQuokka
Gif
Discover more
Curated from across