GigglyNarwhal

✅️How to do great PR Reviews?

Hi folks, Wanted some tips on how to do good PR reviews? Also how do you make sure you don't hurt someone's ego during PR reviews, especially developers who are senior to you?

22mo ago

Jobs

One interview, 1000+ job opportunities

Take a 10-min AI interview to qualify for numerous real jobs auto-matched to your profile 🔑

+322 new users this month

MagicalQuokka

Stealth22mo

(1) Provide a tag on each comment that you leave - whether it's critical, a minor issue or a nit

(2) Leave comments in a tentative language, maybe even as a suggestive question. "Could we consider doing this?"

(3) It is always best to add a reason justifying your suggestions.

(4) When in doubt, ask a question to understand the change before leaving a possibly unjustified comment.

(5) If you're having too many back-and-forths, just get on a call and resolve all of those sync.

GigglyNarwhal

Stealth22mo

Great stuff Thanks for sharing it

FluffyNugget

Plivo22mo

A junior doing code review for senior? That’s unheard of. Just be humble in ur review? Like don’t comment for code style or something that’s just ur personal opinion.

GigglyNarwhal

Stealth22mo

Not even nits?

FluffyNugget

Plivo22mo

What is nits ?

Discover more

Curated from across

Software Engineers20mo

by ZestyBurritoSoftware Engineer

How to become a better PR reviewer?

I am moving up the ladder so I need to become a good PR reviewer as well.

Software Engineers22mo

by ZippyRaccoonSoftware Engineer

Peer/PR Reviews methodology

How do PR reviews happen in your company? Are there any guidelines you follow to ensure Swift and meaningful reviews on your contributions? Any input or opinions are welcomed