Are getting comments on PRs a grave in IT?
Nope. Best way to learn is when someone comment on your PR 🙂↕️
But they are using it against me saying I am delivering low quality code
Your code != You
Always good to have a second set of eyes going through the changes
Not really, You are lucky if someone is going through your PR thoroughly and giving feedback. Sometime those feedback are just personal opinions (for example instead of writing null == value you should write value == null). So there’s no harm in them, In fact reflecting on those comments help you become better with your code you will understand handling edge cases, you will get to know sometimes additional code might not be needed for something. Overall comments aren’t a bad thing. Just make sure to reduce the number of comments over time by following good practices.
Have this co worker, who kind of leads my current project. He keeps digging into PRs and adding comments even when others from the team approved it.
How do I politely shut down this activity? or do I have to not take offense and just wo...
I am moving up the ladder so I need to become a good PR reviewer as well.