ZoomyPotato
ZoomyPotato
9mo

Comments on PRs

Are getting comments on PRs a grave in IT?

9mo ago
ZestyPotato
ZestyPotato

Nope. Best way to learn is when someone comment on your PR 🙂‍↕️

ZoomyPotato
ZoomyPotato

But they are using it against me saying I am delivering low quality code

ZippyPickle
ZippyPickle
Student
9mo

Your code != You

Always good to have a second set of eyes going through the changes

FluffyDonut
FluffyDonut
9mo

Not really, You are lucky if someone is going through your PR thoroughly and giving feedback. Sometime those feedback are just personal opinions (for example instead of writing null == value you should write value == null). So there’s no harm in them, In fact reflecting on those comments help you become better with your code you will understand handling edge cases, you will get to know sometimes additional code might not be needed for something. Overall comments aren’t a bad thing. Just make sure to reduce the number of comments over time by following good practices.

Discover more
Curated from across